Re: C++ keywords in headers (was Re: [GENERAL] #include ) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: C++ keywords in headers (was Re: [GENERAL] #include )
Date
Msg-id 1293466319-sup-2446@alvh.no-ip.org
Whole thread Raw
In response to Re: C++ keywords in headers (was Re: [GENERAL] #include )  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Excerpts from Peter Eisentraut's message of lun dic 27 12:54:16 -0300 2010:
> On sön, 2010-12-26 at 12:31 -0500, Tom Lane wrote:
> > We did clean up C++ keyword uses in the header files in 9.0, but your
> > report shows it's already gotten broken again.  I'm disinclined to fix
> > it unless someone steps up to create an automated test that will get
> > run reasonably often.  We had that discussion when the patch to rename
> > keyword-named fields was proposed, and nothing got done, and the
> > current state of affairs is the entirely predictable result.
> 
> src/tools/pginclude/cpluspluscheck
> 
> What's missing is to automate this, but it's unclear in what context,
> and perhaps also to what extend this should be a hard requirement.

Maybe we could mention it in src/tools/RELEASE_CHANGES

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Reduce lock levels for ADD and DROP COLUMN
Next
From: Tomas Vondra
Date:
Subject: estimating # of distinct values