Re: use pg_strncasecmp to replace strncmp when compare "pg_" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: use pg_strncasecmp to replace strncmp when compare "pg_"
Date
Msg-id 1286655.1619154381@sss.pgh.pa.us
Whole thread Raw
In response to Re: use pg_strncasecmp to replace strncmp when compare "pg_"  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses RE: use pg_strncasecmp to replace strncmp when compare "pg_"  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
List pgsql-hackers
Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> At Thu, 22 Apr 2021 12:44:28 +0000, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> wrote in
>> When try to improve the tab compleation feature in [1], I found an existing problem and a typo.
>> The patch was attached, please kindly to take a look at it. Thanks.

> That doesn't matter at all for now since we match schema identifiers
> case-sensitively.  Maybe it should be a part of the patch in [1].

Yeah --- maybe this'd make sense as part of a full patch to improve
tab-complete.c's handling of case folding, but I'm suspicious that
applying it on its own would just make things less consistent.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Forgot some LSN_FORMAT_ARGS() in xlogreader.c
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: INT64_FORMAT in translatable strings