Re: Regression tests versus the buildfarm environment - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Regression tests versus the buildfarm environment
Date
Msg-id 1281541324.26522.1.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: Regression tests versus the buildfarm environment  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Regression tests versus the buildfarm environment
Re: Regression tests versus the buildfarm environment
List pgsql-hackers
On ons, 2010-08-11 at 10:15 -0400, Tom Lane wrote:
> > One of us is missing something. I didn't say to run the checks using
> the 
> > configured port. I had in mind something like:
> 
> >      port = 0xC000 | ((PG_VERSION_NUM + DEF_PGPORT) &  0x3FFF);
> 
> Oh, I see, modify the DEF_PGPORT don't just use it as-is.  OK, except
> that I think something like the above is still pretty risky for the
> buildfarm, because you would still have conflicts for assorted
> combinations of version numbers and branch_port settings.
> 
> How about just this:
> 
>      port = 0xC000 | (DEF_PGPORT & 0x3FFF);

The version number was put in there intentionally, for developers who
work on multiple branches at once.  That's the whole reason this code
exists.  Please don't remove it.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: MERGE command for inheritance
Next
From: Peter Eisentraut
Date:
Subject: Re: Regression tests versus the buildfarm environment