Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)
Date
Msg-id 12520.1299430488@sss.pgh.pa.us
Whole thread Raw
In response to Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> Ah. Finally after trying to stare down the code for some more time the issue 
> is pretty simple.

> -        fmgr_info_collation(irel->rd_index->indcollation.values[attnum-1],
> +        fmgr_info_collation(irel->rd_indcollation[attnum-1],

Good catch ... but while I was poking around to make sure that there
were no other similar errors, I started to get pretty desperately
unhappy with the state of this code altogether.  What exactly is
indcollation supposed to mean?  Does it have any meaning for unordered
indexes?  If it means something about the index's sort order, why is it
that it's not consulted while building the pathkeys that represent the
sort order?  (It isn't.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: Sync Rep v19
Next
From: Magnus Hagander
Date:
Subject: Downtime for commitfest.postgresql.org