Re: GIN versus zero-key queries - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: GIN versus zero-key queries
Date
Msg-id 1238100337.11547.79.camel@dell.linuxdev.us.dell.com
Whole thread Raw
In response to GIN versus zero-key queries  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, 2009-03-25 at 13:25 -0400, Tom Lane wrote:
> I am not sure whether the statement in 52.5 is still accurate, though.
> We have an API definition by which extractQuery can distinguish "all
> match" from "no match".  If we just legislate that "some match" isn't
> a valid behavior for zero-key queries, then the code is correct and the
> documentation is wrong.  However, if the above quote is correct, then
> I think newScanKey() is buggy.

Legislating that "some match" is invalid for zero-key queries seems
reasonable to me.

If the operator class author wants it to throw an error for zero keys
(as the documentation says should happen), they can do that easily
enough without being forced. However, if the opclass author finds "all
match" to be useful behavior (which seems reasonable), I don't see a
reason to stop them.

Regards,Jeff Davis



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: maintenance_work_mem and autovacuum
Next
From: Simon Riggs
Date:
Subject: Re: maintenance_work_mem and autovacuum