Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a
Date
Msg-id 12355.1248541671@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a  (adunstan@postgresql.org (Andrew Dunstan))
Responses Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
adunstan@postgresql.org (Andrew Dunstan) writes:
> Log Message:
> -----------
> Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.

This actually broke things a bit.  I agree that the original coding with
a phony list header was horridly ugly, but it did have one redeeming
value: namely that the various existing tests for force_quote not empty
still worked as-is.  With the separate bool you need to extend all those
checks.  On balance it still seems cleaner that way, though, so I made
the necessary fixes.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Code review for FORCE QUOTE * patch: fix error checking to
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a