Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a
Date
Msg-id 4A6B3F00.7080502@dunslane.net
Whole thread Raw
In response to Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers

Tom Lane wrote:
> adunstan@postgresql.org (Andrew Dunstan) writes:
>
>> Log Message:
>> -----------
>> Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.
>>
>
> This actually broke things a bit.  I agree that the original coding with
> a phony list header was horridly ugly, but it did have one redeeming
> value: namely that the various existing tests for force_quote not empty
> still worked as-is.  With the separate bool you need to extend all those
> checks.  On balance it still seems cleaner that way, though, so I made
> the necessary fixes.
>
>
>

Oops! Thanks. That will teach me to code before I have my coffee.

cheers

andrew

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Extend EXPLAIN to allow generic options to be specified.