Re: BUG #1643: dbf2pg broken + quick fix - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #1643: dbf2pg broken + quick fix
Date
Msg-id 12065.1115154932@sss.pgh.pa.us
Whole thread Raw
In response to BUG #1643: dbf2pg broken + quick fix  ("Boris van Schooten" <schooten@cs.utwente.nl>)
Responses Re: BUG #1643: dbf2pg broken + quick fix  (Boris van Schooten <schooten@cs.utwente.nl>)
List pgsql-bugs
"Boris van Schooten" <schooten@cs.utwente.nl> writes:
> As it turns out, the integer checking code (contrib/dbase/dbf2pg.c, function
> isinteger) is broken.  It appears the function reports 0 in case it finds a
> space in the dbf rather than a digit.  I disabled it (always made it return
> 1).  Now, my dbf files import fine.

Hmm.  I know nothing about dbase ... but if the test has any use at all,
I guess it must be to handle NULL values.  How does dbase represent a
NULL?  Why is this code only checking this for integer columns?

            regards, tom lane

pgsql-bugs by date:

Previous
From: "Boris van Schooten"
Date:
Subject: BUG #1643: dbf2pg broken + quick fix
Next
From: Neil Conway
Date:
Subject: Re: BUG #1644: control structeres perfomance in pgsql