tuplestore_putvalues() - Mailing list pgsql-patches

From Neil Conway
Subject tuplestore_putvalues()
Date
Msg-id 1204245473.22273.7.camel@dell.linuxdev.us.dell.com
Whole thread Raw
Responses Re: tuplestore_putvalues()
Re: tuplestore_putvalues()
Re: tuplestore_putvalues()
List pgsql-patches
Attached is a patch that allows an array of Datums + nulls to be
inserted into a tuplestore without first creating a HeapTuple, per
recent suggestion on -hackers. This avoids making an unnecessary copy.
There isn't a really analogous optimization to be applied to tuplesort:
it takes either a TTS, an IndexTuple or a basic Datum, none of which
involve an extra copy.

BTW, I notice that almost all of the callers of the various
tuplestore_put methods switch into the tuplestore's context first. We
could simplify their lives a bit by having the tuplestore remember the
context in which it is allocated and do the switch itself. Perhaps it's
not worth bothering with at this point, though.

-Neil


Attachment

pgsql-patches by date:

Previous
From: Robert Lor
Date:
Subject: Re: DTrace probe patch for OS X Leopard
Next
From: Neil Conway
Date:
Subject: Re: SRF memory leaks