On Wed, 2007-07-18 at 16:59 +0200, Peter Eisentraut wrote:
> It might be good to check the actual definition of NULL in this case, however,
> before wondering further.
Well, the existing coding is plainly wrong, regardless of the NULL
implementation used on any given machine (although it will usually
work). The simple rule is "you need to cast NULL to a pointer type when
passing arguments to a variadic function, or to a function whose
prototype is not in scope".
So +1 on this patch from me.
-Neil
