Re: Distinct tightly coupled with Agg - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Distinct tightly coupled with Agg
Date
Msg-id 1178736.1668538565@sss.pgh.pa.us
Whole thread Raw
In response to Distinct tightly coupled with Agg  (Ankit Kumar Pandey <itsankitkp@gmail.com>)
Responses Re: Distinct tightly coupled with Agg
List pgsql-hackers
Ankit Kumar Pandey <itsankitkp@gmail.com> writes:
> I am looking at todo item (#1) /Implement DISTINCT clause in window 
> aggregates/ and while looking at code, I found distinct tightly coupled 
> with Agg function. Looking at another todo item(#2) /Do we really need 
> so much duplicated code between Agg and WindowAgg/?  I was wondering 
> what is general stance on this? Is #2 per-requisite for #1?

No, I think #2 is just a general statement of annoyance.  It'd be
great if someone finds a way to refactor things to improve that; but
seeing that window functions operate in a much different environment
than plain aggregates, I'm not holding my breath.  It's certainly
not a prerequisite for any other work in the area.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ankit Kumar Pandey
Date:
Subject: Re: Distinct tightly coupled with Agg
Next
From: Andres Freund
Date:
Subject: Re: meson oddities