Re: Typo in ginxlog.c - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Typo in ginxlog.c
Date
Msg-id 1146728814.449.225.camel@localhost.localdomain
Whole thread Raw
In response to Typo in ginxlog.c  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Typo in ginxlog.c  ("Jim C. Nasby" <jnasby@pervasive.com>)
List pgsql-hackers
On Tue, 2006-05-02 at 15:01 -0400, Alvaro Herrera wrote:
> Just noticed a typo in newly added ginxlog.c.  I don't have line
> numbers, but in ginRedoSplit() it reads:
> 
>     PageSetLSN(rpage, lsn);
>     PageSetTLI(lpage, ThisTimeLineID);
>     MarkBufferDirty(rbuffer);
> 
>     PageSetLSN(lpage, lsn);
>     PageSetTLI(lpage, ThisTimeLineID);
>     MarkBufferDirty(lbuffer);
> 
> 
> Notice the first call to PageSetTLI should be
> 
>     PageSetTLI(rpage, ThisTimeLineID);
> 

Well spotted. We'd have not corrected that until someone's db failed.

--  Simon Riggs              EnterpriseDB   http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Rethinking locking for database create/drop vs
Next
From: Martijn van Oosterhout
Date:
Subject: Semi-undocumented functions in libpq