Re: pgsql: Improve internationalization of messages involving type names - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Improve internationalization of messages involving type names
Date
Msg-id 10551.1459188367@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Improve internationalization of messages involving type names  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Improve internationalization of messages involving type names
List pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is.  (I'm not
> quite sure why this is so, but it's the clear majority.)

Actually, I think the general convention is to NOT quote type names
in error messages.  Certainly that's so when using format_type_be()
to produce a name for a not-known-at-compile-time type.  I would
argue that these messages should be written to look the same as if
format_type_be() had been used, and that would mean leaving off
the quotes.

            regards, tom lane


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Update expected file from quoting change
Next
From: Tom Lane
Date:
Subject: pgsql: Document errhidecontext() where it ought to be documented.