Re: pgsql: Improve internationalization of messages involving type names - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Improve internationalization of messages involving type names
Date
Msg-id 20160330214354.GA48283@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Improve internationalization of messages involving type names  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Improve internationalization of messages involving type names
List pgsql-committers
Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Also, change them all to use the same quoting convention, namely that
> > the function name is not to be quoted but the type name is.  (I'm not
> > quite sure why this is so, but it's the clear majority.)
>
> Actually, I think the general convention is to NOT quote type names
> in error messages.  Certainly that's so when using format_type_be()
> to produce a name for a not-known-at-compile-time type.  I would
> argue that these messages should be written to look the same as if
> format_type_be() had been used, and that would mean leaving off
> the quotes.

Ok, I'll change it.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve portability of I/O behavior for the geometric types.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: XLogReader general code cleanup