psql patch for datestyle - Mailing list pgsql-patches

From Oliver Elphick
Subject psql patch for datestyle
Date
Msg-id 1046672988.2173.122.camel@linda.lfix.co.uk
Whole thread Raw
Responses Re: psql patch for datestyle
Re: psql patch for datestyle
Re: psql patch for datestyle
List pgsql-patches
At present, dates are put into a dump in the format specified by the
default datestyle.  This is not portable between installations.

This patch sets DATESTYLE to ISO at the start of a pg_dump, so that the
dates written into the dump will be restorable onto any database,
regardless of how its default datestyle is set.

Index: pg_dump.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/bin/pg_dump/pg_dump.c,v
retrieving revision 1.317
diff -u -r1.317 pg_dump.c
--- pgsql-orig/src/bin/pg_dump/pg_dump.c   2003/02/13 04:54:16     1.317
+++ pgsql/src/bin/pg_dump/pg_dump.c   2003/03/03 06:22:34
@@ -546,6 +546,13 @@
                                          PQerrorMessage(g_conn));
        PQclear(res);

+       /* Set the datestyle to ISO to ensure the dump's portability */
+       res = PQexec(g_conn, "SET DATESTYLE = ISO");
+       if (!res || PQresultStatus(res) != PGRES_COMMAND_OK)
+               exit_horribly(g_fout, NULL, "could not set datestyle to
ISO: %s",
+                                         PQerrorMessage(g_conn));
+       PQclear(res);
+
        /*
         * If supported, set extra_float_digits so that we can dump
float data
         * exactly (given correctly implemented float I/O code, anyway)



--
Oliver Elphick                                Oliver.Elphick@lfix.co.uk
Isle of Wight, UK                             http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839  932A 614D 4C34 3E1D 0C1C
                 ========================================
     "A new commandment I give to you, that you love one
      another, even as I have loved you."
                                        John 13:34


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: PGRES_POLLING_ACTIVE is unused...
Next
From: Christopher Kings-Lynne
Date:
Subject: Off topic - was Re: ALTER SEQUENCE