Re: PGRES_POLLING_ACTIVE is unused... - Mailing list pgsql-patches

From Tom Lane
Subject Re: PGRES_POLLING_ACTIVE is unused...
Date
Msg-id 813.1046669889@sss.pgh.pa.us
Whole thread Raw
In response to PGRES_POLLING_ACTIVE is unused...  (Lennert Buytenhek <buytenh@gnu.org>)
Responses Re: PGRES_POLLING_ACTIVE is unused...  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Lennert Buytenhek <buytenh@gnu.org> writes:
> ...any reason why it is there at all?

Good question.  Some digging in CVS shows that it was unused even in the
patch that introduced it, and never has been used in any release since.
So it does seem like useless complication.

However, I think it'd be unwise to remove the constant from libpq-fe.h,
because that would break the application of any poor sod who believed
the documentation and wrote code that actually checks for
PGRES_POLLING_ACTIVE.

I'd be inclined to remove it from the documentation and the library
innards, but leave something like this in libpq-fe.h:

    PGRES_POLLING_ACTIVE    /* unused; keep for awhile for
                 * backwards compatibility */


            regards, tom lane

pgsql-patches by date:

Previous
From: Rod Taylor
Date:
Subject: ALTER SEQUENCE
Next
From: Oliver Elphick
Date:
Subject: psql patch for datestyle