Re: pgindent vs dtrace on macos - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent vs dtrace on macos
Date
Msg-id 1023612.1600716072@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent vs dtrace on macos  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pgindent vs dtrace on macos
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Sep-21, Tom Lane wrote:
>> Here's a proposed patch to fix it that way.

> pgtypes_numeric.h still contains
> typedef struct
> {
> } numeric;

> ... isn't this more likely to create a typedef entry than merely a
> function name?

Well, yeah, it *is* a typedef.  My proposal is to rename the C function
to avoid the conflict, rather than renaming the typedef.  Given the
small number of direct calls (none), that's a lot less work.  Also,
I think pgtypes_numeric.h is exposed to ecpg client code, so changing
that typedef's name could be quite problematic.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgindent vs dtrace on macos
Next
From: Alvaro Herrera
Date:
Subject: Re: pgindent vs dtrace on macos