Re: pgindent vs dtrace on macos - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgindent vs dtrace on macos
Date
Msg-id 20200921190804.GA2817@alvherre.pgsql
Whole thread Raw
In response to Re: pgindent vs dtrace on macos  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgindent vs dtrace on macos
List pgsql-hackers
On 2020-Sep-21, Tom Lane wrote:

> Oh wait, I forgot about the fmgrprotos.h discrepancy.
> 
> I wrote:
> > It strikes me that a low-cost workaround would be to rename these
> > C functions.  There's no law that their C names must match the
> > SQL names.
> 
> Here's a proposed patch to fix it that way.

pgtypes_numeric.h still contains

typedef struct
{
    int         ndigits;        /* number of digits in digits[] - can be 0! */
    int         weight;         /* weight of first digit */
    int         rscale;         /* result scale */
    int         dscale;         /* display scale */
    int         sign;           /* NUMERIC_POS, NUMERIC_NEG, or NUMERIC_NAN */
    NumericDigit *buf;          /* start of alloc'd space for digits[] */
    NumericDigit *digits;       /* decimal digits */
} numeric;

... isn't this more likely to create a typedef entry than merely a
function name?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgindent vs dtrace on macos
Next
From: Tom Lane
Date:
Subject: Re: pgindent vs dtrace on macos