pg_dump getBlobs query broken for 7.3 servers - Mailing list pgsql-hackers

From Amit Langote
Subject pg_dump getBlobs query broken for 7.3 servers
Date
Msg-id 0a3e7a0e-37bd-8427-29bd-958135862f0a@lab.ntt.co.jp
Whole thread Raw
Responses Re: pg_dump getBlobs query broken for 7.3 servers  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Re: pg_dump getBlobs query broken for 7.3 servers  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Just noticed that the getBlobs() query does not work for a 7.3 server
(maybe <= 7.3) due to the following change in commit 23f34fa4 [1]:

     else if (fout->remoteVersion >= 70100)
         appendPQExpBufferStr(blobQry,
-                             "SELECT DISTINCT loid, NULL::oid, NULL::oid"
+                             "SELECT DISTINCT loid, NULL::oid, NULL, "
+                             "NULL AS rlomacl, NULL AS initlomacl, "
+                             "NULL AS initrlomacl "
                              " FROM pg_largeobject");
     else
         appendPQExpBufferStr(blobQry,
-                             "SELECT oid, NULL::oid, NULL::oid"
+                             "SELECT oid, NULL::oid, NULL, "
+                             "NULL AS rlomacl, NULL AS initlomacl, "
+                             "NULL AS initrlomacl "
                              " FROM pg_class WHERE relkind = 'l'");

The following error is reported by the server:

pg_dump: [archiver (db)] query failed: ERROR:  Unable to identify an
ordering operator '<' for type '"unknown"'
    Use an explicit ordering operator or modify the query
pg_dump: [archiver (db)] query was: SELECT DISTINCT loid, NULL::oid, NULL,
NULL AS rlomacl, NULL AS initlomacl, NULL AS initrlomacl  FROM pg_largeobject

I could fix that using the attached patch.

Thanks,
Amit

[1]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=23f34fa4ba358671adab16773e79c17c92cbc870

Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw : altering foreign table not invalidating prepare statement execution plan.
Next
From: Alfred Perlstein
Date:
Subject: Re: pgbench vs. wait events