weird comments in Memoize nodes - Mailing list pgsql-hackers

From Peter Eisentraut
Subject weird comments in Memoize nodes
Date
Msg-id 0635f5aa-4973-8dc2-4e4e-df9fd5778a65@enterprisedb.com
Whole thread Raw
Responses Re: weird comments in Memoize nodes  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Consider:

typedef struct Memoize
{
     Plan        plan;

     int         numKeys;        /* size of the two arrays below */

     Oid        *hashOperators;  /* hash operators for each key */
     Oid        *collations;     /* cache keys */
     List       *param_exprs;    /* exprs containing parameters */
     ...

I think the comment "cache keys" is weird here.  Maybe it was copied from

typedef struct MemoizePath
{
     Path        path;
     Path       *subpath;        /* outerpath to cache tuples from */
     List       *hash_operators; /* hash operators for each key */
     List       *param_exprs;    /* cache keys */
     ...

but it's attached to a different field there.

Is this a mistake, or could this be clarified?



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Minor improvements to test log navigability
Next
From: Dan Lynch
Date:
Subject: Postgres AST Deparser for Postgres