Re: Minor improvements to test log navigability - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Minor improvements to test log navigability
Date
Msg-id 1377860.1652717904@sss.pgh.pa.us
Whole thread Raw
In response to Re: Minor improvements to test log navigability  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Minor improvements to test log navigability
Re: Minor improvements to test log navigability
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-May-16, Thomas Munro wrote:
>> 1.  It seems a bit useless to have a load of "FATAL:  the database
>> system is in recovery mode" spam whenever the server crashes under
>> src/test/regress.  Any reason not to just turn that off, as we do for
>> the TAP tests?

> I don't know of any.  Let's.

Have you actually tested what happens?  I fear this would just
result in different spam.

>> 2.  The TAP test logs are strangely named.  Any reason not to call
>> them 001_testname.log, instead of regress_log_001_testname, so they
>> appear next to the corresponding
>> 001_testname_{primary,standby,xxx}.log in directory listings (CI) and
>> dumps (build farm, presumably), and have a traditional .log suffix?

> +1.

Andrew would have to weigh in on whether this'd break the buildfarm,
but if it doesn't, +1.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [RFC] building postgres with meson -v8
Next
From: Peter Eisentraut
Date:
Subject: weird comments in Memoize nodes