> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 10 October 2003 11:12
> To: Dave Page
> Cc: pgadmin-support@postgresql.org
> Subject: Re: [pgadmin-support] Keep-alive?
>
> Yes, and a harsh one :-(
>
> This is just what I meant that should *not* be implemented.
> - It will throw an error every 5 seconds, after blocking the
> connection for a failed heartbeat. Implemented this way, it's
> more a watchdog, that won't stop barking.
I did say I was only fiddling, hence why I posted a demo patch rather
than just committing code. I was after feedback before spending too much
time on it.
> - If a broken conn is detected, it must be marked dead.
Yes, of course.
> - This feature is exotic, and must not be active by default.
Agreed.
> - 5 seconds is ridiculously short.
Obviously you didn't read my email where I clearly stated that this
would not remain hard coded. For testing purposes 5 seconds is fine.
> - it should fire after n seconds of inactivity, not every n seconds
Yes, it should and it was. I must have lost part of the code.
> - this works only for the main window, not for those getting
> their own connection. The wxWin timer will conflict with the
> threaded executed queries, because it's not aware of
> previously or currently executed queries.
It purposefully only works on the master connection to each server as
there is no point in individually polling individual databases on the
same server. Unless you've changed the code from what I originally
wrote, the master connection will never be used for threaded queries.
> - Does it work at all? pgConn is no window, so where should
> the message come from?
Yes of course it works, I didn't just randomly type code and post it:
class pgConn : wxFrame
Regards, Dave.
