Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for HP-UX IA-64 - Mailing list pgsql-patches
| From | ViSolve Open Source Team |
|---|---|
| Subject | Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for HP-UX IA-64 |
| Date | |
| Msg-id | 015c01c3b927$554b7ee0$70800d0f@NETMERCURY Whole thread Raw |
| Responses |
Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4
Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for |
| List | pgsql-patches |
Bruce,
Thanks for the comments/questions. A couple of points in response:
1. About the #if defined (_HP_aCC) || defined (_HP_cc)
We agree. That line can go.
2. About the TMPFILE definition change from .c to .h: Unfortunately, the -V option does not work the same way across HP compilers (it works as expected with HP aCC, but not with HP cc).
We have a couple of alternatives here.
We have a couple of alternatives here.
a. Using `uname` (to look for HP-UX) and checking to see if $CPP is set to /usr/bin/cc or /opt/aCC/bin/aCC. Not good.
b. Doing nothing. The TMPFILE mod is a trivial change to make with each new version of PostgreSQL that we build for HP-UX. (We had in fact suggested this in our original request email). So if you make no changes to the TMPFILE code, that will be fine too.
thanks
ViSolve OpenSource Team
============================================================================
Return-Path: <pgman@candle.pha.pa.us
Received: (qmail 20935 invoked from network); 30 Nov 2003 04:33:45 -0000
Received: from canlde.pha.pa.us (HELO candle.pha.pa.us) ([207.106.42.251])
(envelope-sender <pgman@candle.pha.pa.us)
by visolve.com (qmail-ldap-1.03) with SMTP
for <opensrc_support_hp@visolve.com; 30 Nov 2003 04:33:45 -0000
Received: (from pgman@localhost)
by candle.pha.pa.us (8.11.6/8.11.6) id hAU4Xcs26486;
Sat, 29 Nov 2003 23:33:38 -0500 (EST)
From: Bruce Momjian <pgman@candle.pha.pa.us
Message-Id: <200311300433.hAU4Xcs26486@candle.pha.pa.us
Subject: Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for HP-UX
IA-64
In-Reply-To: <019301c3af01$029c9470$70800d0f@NETMERCURY
To: ViSolve Open Source Team <opensrc_support_hp@visolve.com
Date: Sat, 29 Nov 2003 23:33:38 -0500 (EST)
CC: PostgreSQL-patches <pgsql-patches@postgresql.org,
Peter Eisentraut <peter_e@gmx.net
X-Mailer: ELM [version 2.4ME+ PL108 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Received: (qmail 20935 invoked from network); 30 Nov 2003 04:33:45 -0000
Received: from canlde.pha.pa.us (HELO candle.pha.pa.us) ([207.106.42.251])
(envelope-sender <pgman@candle.pha.pa.us)
by visolve.com (qmail-ldap-1.03) with SMTP
for <opensrc_support_hp@visolve.com; 30 Nov 2003 04:33:45 -0000
Received: (from pgman@localhost)
by candle.pha.pa.us (8.11.6/8.11.6) id hAU4Xcs26486;
Sat, 29 Nov 2003 23:33:38 -0500 (EST)
From: Bruce Momjian <pgman@candle.pha.pa.us
Message-Id: <200311300433.hAU4Xcs26486@candle.pha.pa.us
Subject: Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for HP-UX
IA-64
In-Reply-To: <019301c3af01$029c9470$70800d0f@NETMERCURY
To: ViSolve Open Source Team <opensrc_support_hp@visolve.com
Date: Sat, 29 Nov 2003 23:33:38 -0500 (EST)
CC: PostgreSQL-patches <pgsql-patches@postgresql.org,
Peter Eisentraut <peter_e@gmx.net
X-Mailer: ELM [version 2.4ME+ PL108 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
ViSolve Open Source Team wrote:
Subject: PostgreSQL Patch: Modified Test-and-set routine for HP-UX
(IA-64) specifically for the HP-C compiler
Subject: PostgreSQL Patch: Modified Test-and-set routine for HP-UX
(IA-64) specifically for the HP-C compiler
With reference to Tom Lane's response to our previous patch request (at
http://archives.postgresql.org/pgsql-bugs/2003-10/msg00149.php)
this is a modified and more focussed patch request for PostgreSQL for
for HP-UX 11i V2 for the Intel Itanium architecture (known to the
PostgreSQL code as IA-64).
http://archives.postgresql.org/pgsql-bugs/2003-10/msg00149.php)
this is a modified and more focussed patch request for PostgreSQL for
for HP-UX 11i V2 for the Intel Itanium architecture (known to the
PostgreSQL code as IA-64).
Peter mentioned:
>What is this line all about?
>+#if defined(__HP_aCC) || defined(__HP_cc)
>There are no other compilers supported, so this seems redundant.
OK, I will remove this check.
Peter also mentioned:
>You're doing this:
>-TMPFILE="$TMPDIR/genbkitmp$$.c"
>+TMPFILE="$TMPDIR/genbkitmp$$.h"
>+TMPFILE="$TMPDIR/genbkitmp$$.h"
I'm afraid this will not fly, because calling the preprocessor is only
portable on .c files. Generally, it's also unwise to rely in this kind
of subtle side effect. We need a general solution.
portable on .c files. Generally, it's also unwise to rely in this kind
of subtle side effect. We need a general solution.
Can you give us a way to test for your preprocessor? Is there some
unique output like --version or -V that we can test and use *.h only
in that case?
unique output like --version or -V that we can test and use *.h only
in that case?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
====================================================================================
pgsql-patches by date: