Re: pg_dump.options.diff - Mailing list pgsql-hackers

From Serguei Mokhov
Subject Re: pg_dump.options.diff
Date
Msg-id 005701c2b2b1$8e923fe0$0301a8c0@gunnymede.lan
Whole thread Raw
In response to pg_dump.options.diff  ("Serguei Mokhov" <mokhov@cs.concordia.ca>)
Responses Re: pg_dump.options.diff  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
----- Original Message -----
From: "Tom Lane" <tgl@sss.pgh.pa.us>
Sent: January 02, 2003 3:20 PM

> > #if defined(HAVE_GETOPT_LONG)
> > #define xo(long,short,desc)  printf("%s %s\n", long, desc)
> > #else
> > #define xo(long,short,desc)  printf("%s %s\n", short, desc)
> > #endif
>
> > seems relatively generic, so it could be used by more than one tool.
>
> But there's no good place to put it.  I'd say just stick it into each
> tool; it's no worse than repeating the existence of a "usage()"
> subroutine in each tool.

It ended up being in dumputils.h

Attached a patch for pg_dump(all) and pg_restore eliminating dupes
in option descriptions as per above xo "technology".

Please review and apply if there are no too many objections.

thank you,
-s

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Bug in pg_get_constraintdef (for deferrable constraints)
Next
From: Peter Eisentraut
Date:
Subject: Re: PostgreSQL Password Cracker