Re: SetVariable - Mailing list pgsql-hackers

From Mendola Gaetano
Subject Re: SetVariable
Date
Msg-id 003901c370a9$d36bff00$32add6c2@mm.eutelsat.org
Whole thread Raw
In response to Re: SetVariable  ("Gaetano Mendola" <mendola@bigfoot.com>)
Responses Re: SetVariable
List pgsql-hackers
"Bruce Momjian" <pgman@candle.pha.pa.us> wrote:
> Gaetano Mendola wrote:
> > "Bruce Momjian" <pgman@candle.pha.pa.us> wrote:
> > > I see other strdup() calls that don't check on a return.  Should we
deal
> > > with those too?
> >
> > Well strdup obtain the memory for the new string using a malloc
> > and normally is a good habit check the return value of a malloc.
>
> Right.  My point is that we have lots of other strdup's in the code.
> Should we fix those too?  Seems we should be consistent.

Shall I post the patch for SetVariable ?

I know that this change is not so important but I want to try
on my skin the cycle
seen somethink wrong => send patch => be applyed

Regards
Gaetano Mendola




pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Next
From: Bruce Momjian
Date:
Subject: Re: array constructor can't construct empty array