Thread: pgsql: Standardize LSN formatting by zero padding

pgsql: Standardize LSN formatting by zero padding

From
Álvaro Herrera
Date:
Standardize LSN formatting by zero padding

This commit standardizes the output format for LSNs to ensure consistent
representation across various tools and messages.  Previously, LSNs were
inconsistently printed as `%X/%X` in some contexts, while others used
zero-padding.  This often led to confusion when comparing.

To address this, the LSN format is now uniformly set to `%X/%08X`,
ensuring the lower 32-bit part is always zero-padded to eight
hexadecimal digits.

Author: Japin Li <japinli@hotmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/ME0P300MB0445CA53CA0E4B8C1879AF84B641A@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2633dae2e4876a9b7cb90ba025e930a553e5107f

Modified Files
--------------
contrib/amcheck/verify_nbtree.c                    |  46 ++--
contrib/pageinspect/expected/gist.out              |  18 +-
contrib/pageinspect/expected/page.out              |   6 +-
contrib/pageinspect/rawpage.c                      |   2 +-
contrib/pg_walinspect/expected/pg_walinspect.out   |   8 +-
contrib/pg_walinspect/pg_walinspect.c              |  20 +-
doc/src/sgml/catalogs.sgml                         |   2 +-
doc/src/sgml/logical-replication.sgml              |  20 +-
doc/src/sgml/logicaldecoding.sgml                  |  92 ++++----
doc/src/sgml/pageinspect.sgml                      |  12 +-
doc/src/sgml/pglogicalinspect.sgml                 |   4 +-
doc/src/sgml/pgwalinspect.sgml                     |  12 +-
doc/src/sgml/test-decoding.sgml                    |  44 ++--
src/backend/access/rmgrdesc/replorigindesc.c       |   2 +-
src/backend/access/rmgrdesc/xactdesc.c             |   6 +-
src/backend/access/rmgrdesc/xlogdesc.c             |   6 +-
src/backend/access/transam/timeline.c              |   4 +-
src/backend/access/transam/twophase.c              |   8 +-
src/backend/access/transam/xlog.c                  |  57 +++--
src/backend/access/transam/xlogbackup.c            |   8 +-
src/backend/access/transam/xlogprefetcher.c        |  16 +-
src/backend/access/transam/xlogreader.c            |  62 +++---
src/backend/access/transam/xlogrecovery.c          | 160 +++++++-------
src/backend/access/transam/xlogutils.c             |   2 +-
src/backend/backup/backup_manifest.c               |   2 +-
src/backend/backup/basebackup_copy.c               |   2 +-
src/backend/backup/basebackup_incremental.c        |  14 +-
src/backend/commands/subscriptioncmds.c            |   2 +-
src/backend/postmaster/walsummarizer.c             |  28 +--
.../libpqwalreceiver/libpqwalreceiver.c            |   2 +-
src/backend/replication/logical/logical.c          |  14 +-
src/backend/replication/logical/origin.c           |   6 +-
src/backend/replication/logical/slotsync.c         |  10 +-
src/backend/replication/logical/snapbuild.c        |  46 ++--
src/backend/replication/logical/tablesync.c        |   2 +-
src/backend/replication/logical/worker.c           |  20 +-
src/backend/replication/repl_gram.y                |   4 +-
src/backend/replication/repl_scanner.l             |   2 +-
src/backend/replication/slot.c                     |   4 +-
src/backend/replication/slotfuncs.c                |   2 +-
src/backend/replication/syncrep.c                  |   4 +-
src/backend/replication/walreceiver.c              |  16 +-
src/backend/replication/walsender.c                |  32 +--
src/backend/storage/ipc/standby.c                  |   4 +-
src/backend/utils/adt/pg_lsn.c                     |   2 +-
src/bin/pg_basebackup/pg_basebackup.c              |   6 +-
src/bin/pg_basebackup/pg_createsubscriber.c        |   4 +-
src/bin/pg_basebackup/pg_receivewal.c              |  10 +-
src/bin/pg_basebackup/pg_recvlogical.c             |  14 +-
src/bin/pg_basebackup/receivelog.c                 |   6 +-
src/bin/pg_basebackup/streamutil.c                 |   4 +-
src/bin/pg_combinebackup/backup_label.c            |   2 +-
src/bin/pg_combinebackup/pg_combinebackup.c        |   2 +-
src/bin/pg_combinebackup/write_manifest.c          |   2 +-
src/bin/pg_controldata/pg_controldata.c            |  12 +-
src/bin/pg_rewind/libpq_source.c                   |   2 +-
src/bin/pg_rewind/parsexlog.c                      |  18 +-
src/bin/pg_rewind/pg_rewind.c                      |  10 +-
src/bin/pg_rewind/timeline.c                       |   2 +-
src/bin/pg_verifybackup/pg_verifybackup.c          |   2 +-
src/bin/pg_waldump/pg_waldump.c                    |  18 +-
src/common/parse_manifest.c                        |   2 +-
src/include/access/xlogdefs.h                      |   5 +-
src/test/recovery/t/016_min_consistency.pl         |   2 +-
src/test/regress/expected/numeric.out              |  12 +-
src/test/regress/expected/pg_lsn.out               | 240 ++++++++++-----------
src/test/regress/expected/subscription.out         | 152 ++++++-------
67 files changed, 681 insertions(+), 681 deletions(-)