Downloads
Home   >   mailing lists

Thread: [PATCH] plperl: use xsubpp -output unconditionally

[PATCH] plperl: use xsubpp -output unconditionally

From
Dagfinn Ilmari Mannsåker
Date:
Hi hackers,

I noticed that the PL/Perl makefile makes the use of the -output option
conditional on coverage+vpath, because that option is not supported
until Perl 5.9.3.  But these days we require Perl 5.14, so we can remove
that conditional (which also matches what Meson does).  Please see the
attached.

- ilmari

From cb22019c0f9d42f2dffd7399594192458420f4a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org>
Date: Wed, 2 Jul 2025 15:22:21 +0100
Subject: [PATCH] Make use of xsubpp -output unconditional

It was kept conditional on coverage+vpath because Perl before 5.9.3
didn't support it, but we now require 5.14, so that's unnecessary.

This also matches what Meson does.
---
 src/pl/plperl/GNUmakefile | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/pl/plperl/GNUmakefile b/src/pl/plperl/GNUmakefile
index 558c764aadb..a0c59cd8e27 100644
--- a/src/pl/plperl/GNUmakefile
+++ b/src/pl/plperl/GNUmakefile
@@ -91,13 +91,7 @@ all: all-lib
 
 %.c: %.xs
     @if [ x"$(perl_privlibexp)" = x"" ]; then echo "configure switch --with-perl was not specified."; exit 1; fi
-# xsubpp -output option is required for coverage+vpath, but requires Perl 5.9.3
-ifeq ($(enable_coverage)$(vpath_build),yesyes)
     $(PERL) $(XSUBPPDIR)/ExtUtils/xsubpp -typemap $(perl_privlibexp)/ExtUtils/typemap -output $@ $<
-else
-    $(PERL) $(XSUBPPDIR)/ExtUtils/xsubpp -typemap $(perl_privlibexp)/ExtUtils/typemap $< >$@
-endif
-
 
 install: all install-lib install-data
 
-- 
2.50.0

Re: [PATCH] plperl: use xsubpp -output unconditionally

From
Daniel Gustafsson
Date:
> On 2 Jul 2025, at 16:29, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote:

> I noticed that the PL/Perl makefile makes the use of the -output option
> conditional on coverage+vpath, because that option is not supported
> until Perl 5.9.3.  But these days we require Perl 5.14, so we can remove
> that conditional (which also matches what Meson does).  Please see the
> attached.

Nice catch.  On that note, shouldn't we also be updating ppport.h with a new
--compat-version run?

--
Daniel Gustafsson