Thread: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().
copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Avoid dependence on setlocale(). No behavior change. Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c162@eisentraut.org Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4c787a24e7e220a60022e47c1776f22f72902899 Modified Files -------------- src/backend/commands/copyfromparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
On Tue, Jun 10, 2025 at 2:24 PM Jeff Davis <jdavis@postgresql.org> wrote: > copyfromparse.c: use pg_ascii_tolower() rather than tolower(). > > Avoid dependence on setlocale(). No behavior change. > > Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c162@eisentraut.org > Reviewed-by: Peter Eisentraut <peter@eisentraut.org> All 3 of these commits seem like things that could just as well have been done after we branch. -- Robert Haas EDB: http://www.enterprisedb.com
On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote: > All 3 of these commits seem like things that could just as well have > been done after we branch. Yeah, I called out my mistake here: https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710065.camel%40j-davis.com Nobody seemed terribly upset about it so I left them. But for the sake of ending any confusion I just reverted them. I will reapply them in a few weeks after the branch. Regards, Jeff Davis
On Wed, Jun 11, 2025 at 6:15 PM Jeff Davis <pgsql@j-davis.com> wrote: > On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote: > > All 3 of these commits seem like things that could just as well have > > been done after we branch. > > Yeah, I called out my mistake here: > > https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710065.camel%40j-davis.com > > Nobody seemed terribly upset about it so I left them. But for the sake > of ending any confusion I just reverted them. I will reapply them in a > few weeks after the branch. Sounds good. I don't know if those commits mattered or not; my main intention was to make sure you weren't planning to keep going. But short-term revert seems to minimize risk, so +1 from me. -- Robert Haas EDB: http://www.enterprisedb.com