Postgres Pro
Downloads
Home   >   mailing lists

Thread: [bug] keyword commit being accepted for column name

[bug] keyword commit being accepted for column name

From
Vinícius Abrahão
Date:
postgres=# create table postgres_git_repository(commit text, first_line_commit text);
CREATE TABLE
postgres=# create table postgres_git_repository2("commit" text, first_line_commit text);
CREATE TABLE
postgres=# create table postgres_git_repository3("COMMIT" text, first_line_commit text);
CREATE TABLE

postgres=# select version();
                                                version                                                
--------------------------------------------------------------------------------------------------------
 PostgreSQL 17.4 on x86_64-pc-linux-gnu, compiled by clang version 19.1.7 (CentOS 19.1.7-1.el9), 64-bit

postgres=# \d postgres_git_repository
          Table "public.postgres_git_repository"
      Column       | Type | Collation | Nullable | Default
-------------------+------+-----------+----------+---------
 commit            | text |           |          |
 first_line_commit | text |           |          | 

postgres=# \h commit
Command:     COMMIT
Description: commit the current transaction
Syntax:
COMMIT [ WORK | TRANSACTION ] [ AND [ NO ] CHAIN ]

URL: https://www.postgresql.org/docs/17/sql-commit.html

Re: [bug] keyword commit being accepted for column name

From
"David G. Johnston"
Date:
On Saturday, May 31, 2025, Vinícius Abrahão <vinnix.bsd@gmail.com> wrote:
postgres=# create table postgres_git_repository(commit text, first_line_commit text);
CREATE TABLE
postgres=# create table postgres_git_repository2("commit" text, first_line_commit text);
CREATE TABLE
postgres=# create table postgres_git_repository3("COMMIT" text, first_line_commit text);
CREATE TABLE


Only the first of those is even valid here, if you double-quote an identifier it never is even possibly considered a keyword that could conflict.  As for the first one, our reserved words specification doesn’t claim commit as one of them.  Bugs need to things where we claim one thing and implement something different.  Not relative to some external specification.

David J.