Postgres Pro
Downloads
Home   >   mailing lists

Thread: minor fix related to Auxiliary processes and IO workers

minor fix related to Auxiliary processes and IO workers

From
Cédric Villemain
Date:
Hello Andres,


I noticed a comment in "include/miscadmin.h" which might be need a fix:
it states that there is a single auxiliary process of each kind running 
at once.

However, with IO workers it's not true anymore I believe.
See minor patch attached.


---
Cédric Villemain +33 6 20 30 22 52
https://www.Data-Bene.io
PostgreSQL Support, Expertise, Training, R&D
Attachment

Re: minor fix related to Auxiliary processes and IO workers

From
Michael Paquier
Date:
On Tue, May 06, 2025 at 06:25:24PM +0200, Cédric Villemain wrote:
> @@ -353,7 +353,7 @@ typedef enum BackendType
>       * Auxiliary processes. These have PGPROC entries, but they are not
>       * attached to any particular database, and cannot run transactions or
>       * even take heavyweight locks. There can be only one of each of these
> -     * running at a time.
> +     * running at a time, except for IO worker.

Right.  Perhaps this should say "IO workers", no?
--
Michael
Attachment

Re: minor fix related to Auxiliary processes and IO workers

From
Cédric Villemain
Date:


On 07/05/2025 01:52, Michael Paquier wrote:
On Tue, May 06, 2025 at 06:25:24PM +0200, Cédric Villemain wrote:

@@ -353,7 +353,7 @@ typedef enum BackendType 	 * Auxiliary processes. These have PGPROC entries, but they are not 	 * attached to any particular database, and cannot run transactions or 	 * even take heavyweight locks. There can be only one of each of these
-	 * running at a time.
+	 * running at a time, except for IO worker.

Right.  Perhaps this should say "IO workers", no?

Sure, modified this way. 

---
Cédric Villemain +33 6 20 30 22 52
https://www.Data-Bene.io
PostgreSQL Support, Expertise, Training, R&D
Attachment

Re: minor fix related to Auxiliary processes and IO workers

From
Michael Paquier
Date:
On Wed, May 07, 2025 at 03:25:07AM +0200, Cédric Villemain wrote:
> Sure, modified this way.

I have detected two more of these under NumProcSignalSlots and
NumProcStateSlots.  NUM_AUXILIARY_PROCS is adjusted in both cases with
MAX_IO_WORKERS, which is OK, but their comments were incorrect.

Adjusted these two as well, applied the result.
--
Michael
Attachment

Re: minor fix related to Auxiliary processes and IO workers

From
Cédric Villemain
Date:


On 07/05/2025 07:56, Michael Paquier wrote:
On Wed, May 07, 2025 at 03:25:07AM +0200, Cédric Villemain wrote:

Sure, modified this way.

I have detected two more of these under NumProcSignalSlots and
NumProcStateSlots.  NUM_AUXILIARY_PROCS is adjusted in both cases with
MAX_IO_WORKERS, which is OK, but their comments were incorrect.

Adjusted these two as well, applied the result.
Thank you for the other edits. 
---
Cédric Villemain +33 6 20 30 22 52
https://www.Data-Bene.io
PostgreSQL Support, Expertise, Training, R&D