Thread: pgsql: doc: clarify new behavior of max_files_per_process
doc: clarify new behavior of max_files_per_process Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9a9e60fed39268bb85b59dde3cdb0b0166c85cc5 Modified Files -------------- doc/src/sgml/config.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Hi, On 2025-04-29 13:45:44 +0000, Bruce Momjian wrote: > doc: clarify new behavior of max_files_per_process I don't think this really is an improvement - if postmaster is called with a bunch of files already opened, they aren't opened by postmaster, but still are ignored... Greetings, Andres
On Tue, Apr 29, 2025 at 09:52:03AM -0400, Andres Freund wrote:
> Hi,
>
> On 2025-04-29 13:45:44 +0000, Bruce Momjian wrote:
> > doc: clarify new behavior of max_files_per_process
>
> I don't think this really is an improvement - if postmaster is called with a
> bunch of files already opened, they aren't opened by postmaster, but still are
> ignored...
Okay, I was more objecting to the text that wasn't clear; it was:
Sets the maximum number of open files each server subprocess is
allowed to open simultaneously, in addition to the files already
open in postmaster. The default is one thousand files.
The "in addition" wasn't clear to me. I could read it as "adding" the
postmaster file descriptors. I changed it now to:
Sets the maximum number of open files each server subprocess is
allowed to open simultaneously; files opened in the postmaster are
not counted toward this limit. The default is one thousand files.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
On Tue, Apr 29, 2025 at 10:26:50AM -0400, Bruce Momjian wrote:
> On Tue, Apr 29, 2025 at 09:52:03AM -0400, Andres Freund wrote:
> > Hi,
> >
> > On 2025-04-29 13:45:44 +0000, Bruce Momjian wrote:
> > > doc: clarify new behavior of max_files_per_process
> >
> > I don't think this really is an improvement - if postmaster is called with a
> > bunch of files already opened, they aren't opened by postmaster, but still are
> > ignored...
>
> Okay, I was more objecting to the text that wasn't clear; it was:
>
> Sets the maximum number of open files each server subprocess is
> allowed to open simultaneously, in addition to the files already
> open in postmaster. The default is one thousand files.
>
> The "in addition" wasn't clear to me. I could read it as "adding" the
> postmaster file descriptors. I changed it now to:
>
> Sets the maximum number of open files each server subprocess is
> allowed to open simultaneously; files opened in the postmaster are
> not counted toward this limit. The default is one thousand files.
I ended up preserving your "already" too:
Sets the maximum number of open files each server subprocess
is allowed to open simultaneously; files already opened in the
postmaster are not counted toward this limit. The default is one
thousand files.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.