Thread: pgsql: Avoid ERROR at ON COMMIT DELETE ROWS after relhassubclass=f.

pgsql: Avoid ERROR at ON COMMIT DELETE ROWS after relhassubclass=f.

From

Noah Misch

Date:

20 April, 18:30:17

Avoid ERROR at ON COMMIT DELETE ROWS after relhassubclass=f.

Commit 7102070329d8147246d2791321f9915c3b5abf31 fixed a similar bug, but
it missed the case of database-wide ANALYZE ("use_own_xacts" mode).
Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed consequences
from silent discard of a pg_class stats (relpages et al.) update to
ERROR "tuple to be updated was already modified".  Losing a relpages
update of an ON COMMIT DELETE ROWS table was negligible, but a
COMMIT-time error isn't negligible.  Back-patch to v13 (all supported
versions).

Reported-by: Richard Guo <guofenglinux@gmail.com
Reported-by: Robins Tharakan <tharakan@gmail.com>
Discussion: https://postgr.es/m/CAMbWs4-XwMKMKJ_GT=p3_-_=j9rQSEs1FbDFUnW9zHuKPsPNEQ@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a61b67cd06c283d51cc833b4d1b990e6519836d8

Modified Files
--------------
src/backend/commands/vacuum.c                |  2 ++
src/test/regress/expected/maintain_every.out | 33 ++++++++++++++++++++++++++++
src/test/regress/parallel_schedule           |  4 ++++
src/test/regress/sql/maintain_every.sql      | 26 ++++++++++++++++++++++
4 files changed, 65 insertions(+)