Thread: Missing whitespace in pg_restore manpage
Hi all,
the manpage for "pg_restore" tool, in its "--filter" option description,
is missing a whitespace after the reference to "--exclude-schema"
option:
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
index 0ba68ad5305..b6de497aee1 100644
--- a/doc/src/sgml/ref/pg_restore.sgml
+++ b/doc/src/sgml/ref/pg_restore.sgml
@@ -231,7 +231,7 @@ PostgreSQL documentation
or included from restore. The patterns are interpreted according to the
same rules as
<option>-n</option>/<option>--schema</option> for including objects in schemas,
- <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
+ <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
<option>-P</option>/<option>--function</option> for restoring named functions,
<option>-I</option>/<option>--index</option> for restoring named indexes,
<option>-t</option>/<option>--table</option> for restoring named tables
All the best,
bye, lele.
--
nickname: Lele Gaifax | Some people, when confronted with a problem, think "I
real: Emanuele Gaifas | know, I'll use threads." Nothwey htwo pavroble ems.
lele@metapensiero.it | -- Steven D'Aprano, paraphrasing Jamie Zawinski
On 2025/04/14 18:55, Lele Gaifax wrote: > Hi all, > > the manpage for "pg_restore" tool, in its "--filter" option description, > is missing a whitespace after the reference to "--exclude-schema" > option: > > diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml > index 0ba68ad5305..b6de497aee1 100644 > --- a/doc/src/sgml/ref/pg_restore.sgml > +++ b/doc/src/sgml/ref/pg_restore.sgml > @@ -231,7 +231,7 @@ PostgreSQL documentation > or included from restore. The patterns are interpreted according to the > same rules as > <option>-n</option>/<option>--schema</option> for including objects in schemas, > - <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas, > + <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas, > <option>-P</option>/<option>--function</option> for restoring named functions, > <option>-I</option>/<option>--index</option> for restoring named indexes, > <option>-t</option>/<option>--table</option> for restoring named tables Thanks for the report! I think you're right, and I've created a patch based on your suggestion. Since this typo was introduced in v17, the patch should be back-patched to that branch as well. By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email. Could you let me know which name you'd prefer to use as the author in the commit message? For now, I've used "Lele Gaifax" in the attached patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
Attachment
Fujii Masao <masao.fujii@oss.nttdata.com> writes: > By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email. > Could you let me know which name you'd prefer to use as the author in > the commit message? For now, I've used "Lele Gaifax" in the attached patch. I confirm the choice, thank you! bye, lele. -- nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia. lele@metapensiero.it | -- Fortunato Depero, 1929.
On 2025/04/15 14:56, Lele Gaifax wrote: > Fujii Masao <masao.fujii@oss.nttdata.com> writes: > >> By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email. >> Could you let me know which name you'd prefer to use as the author in >> the commit message? For now, I've used "Lele Gaifax" in the attached patch. > > I confirm the choice, thank you! Pushed. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION