Thread: Detach partition with constraint test

Hi,
I tested the "not enforced" constraint feature extensively today
especially the cases of partitioned table. Everything seems to be
working fine.

While doing that, I found that foreign_key.sql does not have a test to
make sure that a partition continues to have the constraints in the
same state after detaching. Here's a 0001 patch adding those tests in
the same block as the not enforced constraints. Probably we could add
similar test in other blocks as well, but I haven't done that yet.
Checking if something like this would be acceptable.

0002 fixes a comment in the same block.

-- 
Best Wishes,
Ashutosh Bapat

On Thu, Apr 3, 2025 at 5:52 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> Hi,
> I tested the "not enforced" constraint feature extensively today
> especially the cases of partitioned table. Everything seems to be
> working fine.
>
> While doing that, I found that foreign_key.sql does not have a test to
> make sure that a partition continues to have the constraints in the
> same state after detaching. Here's a 0001 patch adding those tests in
> the same block as the not enforced constraints. Probably we could add
> similar test in other blocks as well, but I haven't done that yet.
> Checking if something like this would be acceptable.
>
> 0002 fixes a comment in the same block.
>

Thanks for the testing; both patches look quite reasonable to me.

Regards,
Amul