Thread: pgsql: Remove count_one_bits() in acl.c.
Remove count_one_bits() in acl.c. The only caller, select_best_grantor(), can instead use pg_popcount64(). This isn't performance-critical code, but we might as well use the centralized implementation. While at it, add some test coverage for this part of select_best_grantor(). Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org> Discussion: https://postgr.es/m/Z9GtL7Nm6hsYyJnF%40nathan Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/025e7e1eb4b884a187ade19f2ed479b256306a82 Modified Files -------------- src/backend/utils/adt/acl.c | 20 +------------------- src/test/regress/expected/privileges.out | 27 +++++++++++++++++++++++++++ src/test/regress/sql/privileges.sql | 22 ++++++++++++++++++++++ 3 files changed, 50 insertions(+), 19 deletions(-)