Thread: pgsql: refactor: re-add ATExecAlterChildConstr()

pgsql: refactor: re-add ATExecAlterChildConstr()

From
Peter Eisentraut
Date:
refactor: re-add ATExecAlterChildConstr()

ATExecAlterChildConstr() was removed in commit 80d7f990496, but it is
needed in some subsequent patches for the NOT ENFORCED feature, to
recurse over child constraints.  This adds it back in slightly altered
form.

Author: Amul Sul <amul.sul@enterprisedb.com>
Reviewed-by: Alexandra Wang <alexandra.wang.oss@gmail.com>
Discussion:
https://www.postgresql.org/message-id/flat/CAAJ_b962c5AcYW9KUt_R_ER5qs3fUGbe4az-SP-vuwPS-w-AGA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/64224a834ce4c899e878db27b14ea3412a6ddbed

Modified Files
--------------
src/backend/commands/tablecmds.c | 84 ++++++++++++++++++++++++++--------------
1 file changed, 54 insertions(+), 30 deletions(-)


Re: pgsql: refactor: re-add ATExecAlterChildConstr()

From
Álvaro Herrera
Date:
On 2025-Mar-11, Peter Eisentraut wrote:

> refactor: re-add ATExecAlterChildConstr()
> 
> ATExecAlterChildConstr() was removed in commit 80d7f990496, but it is
> needed in some subsequent patches for the NOT ENFORCED feature, to
> recurse over child constraints.  This adds it back in slightly altered
> form.

FWIW I disagree with this approach and I think this particular piece
should not be committed until we have clarity on what is 0008 going to
actually do.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"No tengo por qué estar de acuerdo con lo que pienso"
                             (Carlos Caszeli)