Thread: Re: Documentation website reading widths

On Tue, 2025-03-04 at 14:27 +0300, Noob Trall wrote:
> I’ve simply copied the dark mode button and added placeholder icons. I haven’t tested it,
> I wonder if anybody can try that. It should appear right to the dark mode one.
> The code is in `main.js` file, at the bottom

I looked at the patch, and it is full of noise, like


> diff --git a/media/css/main.css b/media/css/main.css
> index 71364f19..558d7197 100644
> --- a/media/css/main.css
> +++ b/media/css/main.css
> @@ -15,8 +15,8 @@
>  */
>
>  /** CUSTOM FONTS */
> -@import url('/media/css/open-sans-woff.css');
> -@import url('/media/css/open-sans-woff2.css');
> +@import url("/media/css/open-sans-woff.css");
> +@import url("/media/css/open-sans-woff2.css");
>
>  /** STANDARD COLOR DEFINITIONS (complete list) **/
>  :root {
> @@ -59,7 +59,7 @@
>    --carousel-image-bdr-color: #ddd;
>    --carousel-li-active-bg-color: #555;
>    --carousel-li-bg-color: #999;
> -  --carousel-li-sdw-color: rgba(0,0,0,0.2);
> +  --carousel-li-sdw-color: rgba(0, 0, 0, 0.2);
>    --cta-bg-color: #336791;
>    --cta-fg-color: #fff;
>    --cta-header-fg-color: #fff;

That makes it very hard to read and review the patch.
Please don't add any unnecessary changes.

Yours,
Laurenz Albe

On 3/4/25 6:27 AM, Noob Trall wrote:
> The code is in `main.js` file, at the bottom

Thank you for your hard work. However, I was thinking a lot smaller. 
Something like adding one bootstrap class (untested).

Very respectfully,

Kushal

> On 4 Mar 2025, at 13:01, Kushal Hada <kushaldeveloper@gmail.com> wrote:
>
> On 3/4/25 6:27 AM, Noob Trall wrote:
>> The code is in `main.js` file, at the bottom
>
> Thank you for your hard work. However, I was thinking a lot smaller. Something like adding one bootstrap class
(untested).

Off the cuff I think this is more in line with how the website works, so I'd be
inclined to go with this approach.

--
Daniel Gustafsson