Thread: pgsql: Set amcancrosscompare to true for hash
Set amcancrosscompare to true for hash This was missed in the refactoring in patch ce62f2f2a0a, which thus created a regression. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Mark Dilger <mark.dilger@enterprisedb.com> Discussion: https://www.postgresql.org/message-id/flat/E1tngY6-0000UL-2n%40gemulon.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/56ba0463d38c17400a090353db47cf455ce01c3d Modified Files -------------- src/backend/access/hash/hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Is there a discussion somewhere about why valgrind has been failing like this on skink since Saturday? valgrind: Fatal error at startup: a function redirection valgrind: which is mandatory for this platform-tool combination valgrind: cannot be set up. Details of the redirection are: It doesn't seem it could be caused by this commit, but this is the first commit it is failing on and I don't usually see much discussion in reply to the failures on pgsql-buildfarm. - Melanie
Melanie Plageman <melanieplageman@gmail.com> writes:
> Is there a discussion somewhere about why valgrind has been failing
> like this on skink since Saturday?
> valgrind: Fatal error at startup: a function redirection
> valgrind: which is mandatory for this platform-tool combination
> valgrind: cannot be set up. Details of the redirection are:
Looks to me like a broken software update on the host ...
regards, tom lane
Hi, On 2025-03-03 12:48:27 -0500, Tom Lane wrote: > Melanie Plageman <melanieplageman@gmail.com> writes: > > Is there a discussion somewhere about why valgrind has been failing > > like this on skink since Saturday? > > > valgrind: Fatal error at startup: a function redirection > > valgrind: which is mandatory for this platform-tool combination > > valgrind: cannot be set up. Details of the redirection are: > > Looks to me like a broken software update on the host ... Yes. I think I fixed it a bit ago, the current run is running for longer than the last few runs. Hm, independent of that concrete breakage it looks like skink is running far fewer things under valgrind than it used to. Looks like it's related to a buildfarm client upgrade... The next run after this one will probably take a good bit longer. Greetings, Andres Freund