Thread: Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option

Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option

From
vignesh C
Date:
On Wed, 15 Jan 2025 at 13:21, jian he <jian.universality@gmail.com> wrote:
>
> hi.
>
> around src/bin/pg_dump/pg_dump.c line 1117
> right after "ropt->no_comments = dopt.no_comments;"
> we also need add
>     ropt->no_policies = dopt.no_policies;
> ?
>
> overall looks good to me.
> The tests seem wrong per
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5499
> I have no idea how to improve the test.

Here is a rebased version along with the test failure fixes, please
accept the change if you are ok with it.

Regards,
Vignesh

Attachment

Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option

From
Greg Sabino Mullane
Date:
Re-reviewed this patch: still compiles, tests pass, and does what it says on the tin. +1

Cheers,
Greg

--
Enterprise Postgres Software Products & Tech Support