Thread: Commit fest 2025-03
Hi Everyone, The next PostgreSQL CommitFest is starting in a few days, and I wanted to remind everyone to register their patches to ensure they receive the necessary attention and feedback. I've noticed that a few patches are currently unregistered. If you're still evaluating a POC or finalizing the design, you can choose to add it later. However, if a patch is in good shape for review, I encourage you to register it now to maximize its chances of getting feedback. Here are few patches that I felt is not unregistered: 1) Federated Authn/z with OAUTHBEARER - Author - Daniel Gustafsson https://www.postgresql.org/message-id/flat/d1b467a78e0e36ed85a09adf979d04cf124a9d4b.camel%40vmware.com 2) Update docs for UUID data type - Author - Andy Alsup https://www.postgresql.org/message-id/flat/64b18b5cf27cf13237aec6c9fbbf7720c7107419.camel%40cybertec.at#0d201d3c76021bf121b858b53803763b 3) Lock-free XLog Reservation from WAL - Author - Zhiguo https://www.postgresql.org/message-id/flat/PH7PR11MB5796659F654F9BE983F3AD97EF142%40PH7PR11MB5796.namprd11.prod.outlook.com 4) Restrict copying of invalidated replication slots - Author - Shlok Kyal https://www.postgresql.org/message-id/flat/CANhcyEU65aH0VYnLiu%3DOhNNxhnhNhwcXBeT-jvRe1OiJTo_Ayg%40mail.gmail.com 5) MAX_BACKENDS size (comment accuracy) - Author - Jacob Brazeal https://www.postgresql.org/message-id/CA%2BCOZaBO_s3LfALq%3Db%2BHcBHFSOEGiApVjrRacCe4VP9m7CJsNQ%40mail.gmail.com 6) Simplify the logic a bit (src/bin/scripts/reindexdb.c)- Author - Ranier Vilela https://www.postgresql.org/message-id/CAEudQArfqr0-s0VVPSEh=0kgOgBJvFNdGW=xSL5rBcr0WDMQYQ@mail.gmail.com 7) ReplicationSlotRelease() crashes when the instance is in the single user mode - Author - Hayato Kuroda https://www.postgresql.org/message-id/flat/OSCPR01MB14966ED588A0328DAEBE8CB25F5FA2%40OSCPR01MB14966.jpnprd01.prod.outlook.com 8) long-standing data loss bug in initial sync of logical replication - Author - Shlok Kyal https://www.postgresql.org/message-id/CANhcyEXvcwHE54UEnatUKEs7v6jwRQQi_4qC64ngCfw1zTd5hg%40mail.gmail.com If any of these are ready, please add them to the CommitFest page. If you think some are trivial and don’t need to be added, that’s fine too. Looking forward to a productive CommitFest! Regards, Vignesh
On Tue, 25 Feb 2025 at 21:49, vignesh C <vignesh21@gmail.com> wrote: > > If any of these are ready, please add them to the CommitFest page. If > you think some are trivial and don’t need to be added, that’s fine > too. > Looking forward to a productive CommitFest! March 2025 commitfest has started, the current status is: status | start --------------------------------+----------- Needs review: | 198 Waiting on Author: | 37 Ready for Committer: | 33 Committed: | 52 Moved to next CF | 7 Withdrawn: | 12 Rejected: | 1 Returned with Feedback: | 2 Total: | 342 I will be having a look at the commitfest entries, correcting the status if any of them need to be corrected and update the authors. Kindly keep the patch updated so that the reviewers/committers can review the patches and get it committed. Regards, Vignesh
On Mon, 3 Mar 2025 at 15:02, vignesh C <vignesh21@gmail.com> wrote: > > I will be having a look at the commitfest entries, correcting the > status if any of them need to be corrected and update the authors. > Kindly keep the patch updated so that the reviewers/committers can > review the patches and get it committed. The following "Needs review" patches need rebase --------------------------------------- Incorrect result of bitmap heap scan. - Matthias van de Meent Document hostssl related concepts better - David Johnston noreturn attribute for MSVC, C11 - Peter Eisentraut Enhance file_fdw to report processed and skipped tuples in COPY progress - Fujii Masao Logging plan of the currently running query - Atsushi Torikoshi Index Prefetching - Tomas Vondra [CREATE|RE] INDEX CONCURRENTLY with single heap scan and short-term resetting shapshots - Michail Nikolaev Allow partition-wise join when whole row var is needed - Ashutosh Bapat, Alexander Pyhalov Asynchronous MergeAppend Execution - Alexander Pyhalov Limiting overshoot in nbtree SAOP parallel index scans - Matthias van de Meent Use read_stream in index vacuum - Andrey Borodin Adding compression of temporary files - Filip Januš Allow to use an index for ILIKE in more cases - Yugo Nagata Use Bump allocator for HashAgg - Jeff Davis Read stream scalability improvements and AIO-compatibility - Thomas Munro Compress big WAL records - Andrey Borodin Use XLOG_CONTROL_FILE macro everywhere - Anton Melnikov Don't dirty pages while they are getting flushed out - Andres Freund Enable logical decoding when wal_level = 'replica' without a server restart - Masahiko Sawada Logical replication timeout - Shlok Kyal COPY ON_ERROR 'NULL' - jian he Changing shared_buffers without restart - Dmitry Dolgov speedup COPY TO for partitioned table - Jian He Proposal: Progressive explain - Rafael Castro Extensible storage manager API - Andreas Karlsson/Anastasia Lubennikova/Matthias van de Meent/ Tristan Partin Introduce the ability to enable/disable indexes using ALTER INDEX - Shayon Mukherjee general purpose array_sort - Zhao Junwang explain plans for foreign servers - Dinesh Salve Allow CI to only run the compiler warnings task - Bertrand Drouvot Add NetBSD and OpenBSD OSes to Postgres CI - Nazir Bilal Yavuz The following "Ready for committer" patches needs rebase --------------------------------------- Truncate logs by max_log_size - Kirill Gavrilov Patch owners, please provide a rebased version to prepare it for reviewers and committers. Regards, Vignesh
Hi Vignesh On 05.03.25 10:22, vignesh C wrote: > The following "Ready for committer" patches needs rebase > --------------------------------------- > Truncate logs by max_log_size - Kirill Gavrilov > > Patch owners, please provide a rebased version to prepare it for > reviewers and committers. Is there something wrong with the commitfest app? This patch applies cleanly and passes all tests Best, Jim
On Wed, 5 Mar 2025 at 16:50, Jim Jones <jim.jones@uni-muenster.de> wrote: > > Hi Vignesh > > On 05.03.25 10:22, vignesh C wrote: > > The following "Ready for committer" patches needs rebase > > --------------------------------------- > > Truncate logs by max_log_size - Kirill Gavrilov > > > > Patch owners, please provide a rebased version to prepare it for > > reviewers and committers. > > Is there something wrong with the commitfest app? This patch applies > cleanly and passes all tests I verified that it applies neatly and passes the tests for me too, I have reported this issue at [1]. I don't know the reason for this. Let's see if we get any response from the other thread. [1] - https://www.postgresql.org/message-id/CALDaNm3ta7UV_eD%2BObgVsivGgPZSj1YqnO4-ojeBz10J95u7_A%40mail.gmail.com Regards, Vignesh
vignesh C <vignesh21@gmail.com> writes:
> On Wed, 5 Mar 2025 at 16:50, Jim Jones <jim.jones@uni-muenster.de> wrote:
>> Is there something wrong with the commitfest app? This patch applies
>> cleanly and passes all tests
> I verified that it applies neatly and passes the tests for me too, I
> have reported this issue at [1]. I don't know the reason for this.
What did you apply with? "git am" is known to be far pickier than
"patch". (I thought the cfbot was using "patch", but I might be
wrong. There are many versions of "patch", too.)
regards, tom lane
On Thu, 6 Mar 2025 at 21:24, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > vignesh C <vignesh21@gmail.com> writes: > > On Wed, 5 Mar 2025 at 16:50, Jim Jones <jim.jones@uni-muenster.de> wrote: > >> Is there something wrong with the commitfest app? This patch applies > >> cleanly and passes all tests > > > I verified that it applies neatly and passes the tests for me too, I > > have reported this issue at [1]. I don't know the reason for this. > > What did you apply with? "git am" is known to be far pickier than > "patch". (I thought the cfbot was using "patch", but I might be > wrong. There are many versions of "patch", too.) In my local environment I used "git am" and it worked fine. cfbot has used "git apply --3way" as per [1], they are planning to change it to "git am" to fix this issue. [1] - https://www.postgresql.org/message-id/CAGECzQSE7igwsTUk17i%2BRNEUL1zR-Zkp-1Zs7KkhmBxAu_Fksw%40mail.gmail.com Regards, Vignesh
On Wed, 5 Mar 2025 at 16:50, Jim Jones <jim.jones@uni-muenster.de> wrote: > > Hi Vignesh > > On 05.03.25 10:22, vignesh C wrote: > > The following "Ready for committer" patches needs rebase > > --------------------------------------- > > Truncate logs by max_log_size - Kirill Gavrilov > > > > Patch owners, please provide a rebased version to prepare it for > > reviewers and committers. > > Is there something wrong with the commitfest app? This patch applies > cleanly and passes all tests This issue has been addressed now, here are the updated patches that needs to be rebased: The walsender does not update its IO statistics until it exits - Bertrand Drouvot noreturn attribute for MSVC, C11 - Peter Eisentraut Add pg_stat_session - Sergey Dudoladov Logging plan of the currently running query - Atsushi Torikoshi Index Prefetching - Tomas Vondra Allow partition-wise join when whole row var is needed - Alexander Pyhalov Asynchronous MergeAppend Execution - Alexander Pyhalov AIO - Andres Freund Limiting overshoot in nbtree SAOP parallel index scans - Matthias van de Meent Use read_stream in index vacuum - Andrey Borodin Adding compression of temporary files - Filip Janus Allow to use an index for ILIKE in more cases - Yugo NAGATA Use Bump allocator for HashAgg - Jeff Davis Read stream scalability improvements and AIO-compatibility - Thomas Munro Compress big WAL records - Andrey Borodin Reduce timing overhead of EXPLAIN ANALYZE using rdtsc - Lukas Fittl Use XLOG_CONTROL_FILE macro everywhere - Anton A. Melnikov Don't dirty pages while they are getting flushed out - Andres Freund Enable logical decoding when wal_level = 'replica' without a server restart - Masahiko Sawada VACUUM FULL / CLUSTER CONCURRENTLY - Antonin Houska NOT ENFORCED constraint feature - Amul Sul Changing shared_buffers without restart - Ashutosh Bapat Extended Statistics set/restore/clear functions - Corey Huinker general purpose array_sort - jian he explain plans for foreign servers - Dinesh Salve Enable fine-grained control over what gets logged on connection attempt (reduces log size) - Sergey Allow CI to only run the compiler warnings task - Bertrand Drouvot Patch owners, please provide a rebased version to prepare it for reviewers and committers. Regards, Vignesh
On Mon, 3 Mar 2025 at 15:02, vignesh C <vignesh21@gmail.com> wrote: > > On Tue, 25 Feb 2025 at 21:49, vignesh C <vignesh21@gmail.com> wrote: > > > > If any of these are ready, please add them to the CommitFest page. If > > you think some are trivial and don’t need to be added, that’s fine > > too. > > Looking forward to a productive CommitFest! > > March 2025 commitfest has started, the current status is: > status | start > --------------------------------+----------- > Needs review: | 198 > Waiting on Author: | 37 > Ready for Committer: | 33 > Committed: | 52 > Moved to next CF | 7 > Withdrawn: | 12 > Rejected: | 1 > Returned with Feedback: | 2 > Total: | 342 Here's a quick commitfest status report after the first 10 days: status | start | 10th Mar ----------------------------+--------+---------------- Needs review: | 198 | 182 Waiting on Author: | 37 | 35 Ready for Committer:| 33 | 33 Committed: | 52 | 67 Moved to next CF: | 7 | 7 Withdrawn: | 12 | 15 Rejected: | 1 | 1 RWF: | 2 | 2 Total: | 342 | 342 There are currently 67 patches in the "Ready for Committer" status at [1]. If any committers have bandwidth, please consider reviewing and advancing them. If you have submitted a patch that is in the "Waiting for Author" state, please update it to "Needs Review" as soon as possible. This is where reviewers are most likely to focus their efforts. There are 35 patches currently in this state that require updates at [2]. Additionally, 26 patches require a rebase due to recent commits at [3]. Patch owners are requested to rebase and submit updated versions. I will be changing the status of these patches to "Waiting on Author", so please post a rebased version and update the status accordingly. [1] - https://commitfest.postgresql.org/52/?status=3 [2] - https://commitfest.postgresql.org/52/?status=2 [3] - https://commitfest.postgresql.org/52/?status=1 Regards, Vignesh
On Tue, 11 Mar 2025 at 09:41, vignesh C <vignesh21@gmail.com> wrote: > Here's a quick commitfest status report as of today: status | start | 10th | 17th ----------------------------+---------+---------+--------- Needs review: | 198 | 182 | 134 Waiting on Author: | 37 | 35 | 69 Ready for Committer:| 33 | 33 | 34 Committed: | 52 | 67 | 75 Moved to next CF: | 7 | 7 | 11 Withdrawn: | 12 | 15 | 15 Rejected: | 1 | 1 | 3 RWF: | 2 | 2 | 2 Total: | 343 | 343 | 343 Currently, there are 69 patches which are in "Waiting on Author" status at [1]. Please review the feedback, make the necessary updates, and move them to "Needs Review" as soon as possible. Additionally, 12 patches require rebasing, as listed in [2]. I am moving these to "Waiting on Author". Please rebase them and update their status to "Needs Review". Eight patches have been committed in the last week. [1] - https://commitfest.postgresql.org/52/?status=2 [2] - https://commitfest.postgresql.org/52/?status=1 Regards, Vignesh
On Mon, 17 Mar 2025 at 09:26, vignesh C <vignesh21@gmail.com> wrote: > Here's a quick commitfest status report as of today: status | start | 10th | 17th | 24th ----------------------------+---------+---------+---------+--------- Needs review: | 198 | 182 | 134 | 120 Waiting on Author: | 37 | 35 | 69 | 62 Ready for Committer:| 33 | 33 | 34 | 34 Committed: | 52 | 67 | 75 | 90 Moved to next CF: | 7 | 7 | 11 | 14 Withdrawn: | 12 | 15 | 15 | 18 Rejected: | 1 | 1 | 3 | 3 RWF: | 2 | 2 | 2 | 2 Total: | 343 | 343 | 343 | 343 There are currently 34 patches in the "Ready for Committer" status at [1]. If any committers have bandwidth, please consider reviewing and advancing them. If you have submitted a patch that is in the "Waiting for Author" state, please update it to "Needs Review" as soon as possible. This is where reviewers are most likely to focus their efforts. There are 62 patches that are in "Waiting for Author" state at [2]. Additionally, 13 Needs review patches require a rebase due to recent commits at [3]. Patch owners are requested to rebase and submit updated versions. 15 patches have been committed in the last week. [1] - https://commitfest.postgresql.org/52/?status=3 [2] - https://commitfest.postgresql.org/52/?status=2 [3] - https://commitfest.postgresql.org/52/?status=1 Regards, Vignesh
On Mon, 24 Mar 2025 at 10:07, vignesh C <vignesh21@gmail.com> wrote: > > On Mon, 17 Mar 2025 at 09:26, vignesh C <vignesh21@gmail.com> wrote: > Here's a quick commitfest status report as of today: status | start | 10th | 17th | 24th | 31st ----------------------------+---------+-------+-------+--------+--------- Needs review: | 198 | 182 | 134 | 120 | 105 Waiting on Author: | 37 | 35 | 69 | 62 | 59 Ready for Committer:| 33 | 33 | 34 | 34 | 27 Committed: | 52 | 67 | 75 | 90 | 109 Moved to next CF: | 7 | 7 | 11 | 14 | 16 Withdrawn: | 12 | 15 | 15 | 18 | 18 Rejected: | 1 | 1 | 3 | 3 | 5 RWF: | 2 | 2 | 2 | 2 | 4 Total: | 343 | 343 | 343 | 343 | 343 There are currently 27 patches in the "Ready for Committer" status at [1]. If any committers have bandwidth, please consider reviewing and advancing them. If you have submitted a patch that is in the "Waiting for Author" state, please update it to "Needs Review" as soon as possible. This is where reviewers are most likely to focus their efforts. Additionally, 12 Needs review patches require a rebase due to recent commits at [2]. Patch owners are requested to rebase and submit updated versions. 19 patches have been committed in the last week. [1] - https://commitfest.postgresql.org/52/?status=3 [2] - https://commitfest.postgresql.org/52/?status=1 Regards, Vignesh