Thread: correction

correction

From
PG Doc comments form
Date:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/17/routine-vacuuming.html
Description:

hi i found a tiny error below:
https://www.postgresql.org/docs/current/routine-vacuuming.html
>Drop any old replication slots. Use pg_stat_replication to find slots where
age(xmin) or age(catalog_xmin) is large. In many cases, such slots were
created for replication to servers that no longer exist, or that have been
down for a long time.

not pg_stat_replication but pg_replication_slots 
because pg_stat_replication has neither 
xmin nor catalog_xmin.

thank you

Re: correction

From
"Euler Taveira"
Date:
On Mon, Feb 24, 2025, at 3:52 AM, PG Doc comments form wrote:
hi i found a tiny error below:
>Drop any old replication slots. Use pg_stat_replication to find slots where
age(xmin) or age(catalog_xmin) is large. In many cases, such slots were
created for replication to servers that no longer exist, or that have been
down for a long time.

not pg_stat_replication but pg_replication_slots 
because pg_stat_replication has neither 
xmin nor catalog_xmin.


Good catch! This seems an oversight in commit a70bce43fbc that was
backpatched down to v14. The attached patch should fix it.


--
Euler Taveira

Attachment