Thread: Inconsistent GUC descriptions

Hello, (this mail is not a duplicate sent by mistake.)

The recent commit ac0e33136ab introduced the following message:

+    GUC_check_errdetail("The value of \"%s\" must be set to 0 during binary upgrade mode.",

However, the existing message for the same situation is written
without "The value of" at the beginning. In addition, all existing
messages following the "%s must be set to" pattern omit this phrase.

Therefore, I believe the initial part of the new message should be
removed for consistency. The attached patch makes this adjustment.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Dear Horiguchi-san,

I really appreciate your post-commit reviewing.

> However, the existing message for the same situation is written
> without "The value of" at the beginning.

Right. To clarify, max_slot_wal_keep_size has similar check hook which rejects
the upgrade mode, and it starts with "\"%s\" must be set to".

> In addition, all existing
> messages following the "%s must be set to" pattern omit this phrase.

Yes, effective_io_concurrency and maintenance_io_concurrency start with it.

> Therefore, I believe the initial part of the new message should be
> removed for consistency. The attached patch makes this adjustment.

Agreed. I read your patch just in case and looks good to me...

Best regards,
Hayato Kuroda
FUJITSU LIMITED