Thread: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
Convert heap_vac_scan_next_block() boolean parameters to flags The read stream API only allows one piece of extra per block state to be passed back to the API user (per_buffer_data). lazy_scan_heap() needs two pieces of per-buffer data: whether or not the block was all-visible in the visibility map and whether or not it was eagerly scanned. Convert these two pieces of information to flags so that they can be populated by heap_vac_scan_next_block() and returned to lazy_scan_heap(). A future commit will turn heap_vac_scan_next_block() into the read stream callback for heap phase I vacuuming. Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/CAAKRu_bmx33jTqATP5GKNFYwAg02a9dDtk4U_ciEjgBHZSVkOQ%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/32acad7d1d0a83a1815e15fe28b421d3471ef774 Modified Files -------------- src/backend/access/heap/vacuumlazy.c | 47 +++++++++++++++++++++--------------- 1 file changed, 27 insertions(+), 20 deletions(-)
Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
From
Daniel Gustafsson
Date:
> On 14 Feb 2025, at 18:59, Melanie Plageman <melanieplageman@gmail.com> wrote: > > Convert heap_vac_scan_next_block() boolean parameters to flags This seems to have made skink upset with a Valgrind error: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-02-14%2020%3A30%3A29 -- Daniel Gustafsson
Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
From
Melanie Plageman
Date:
On Fri, Feb 14, 2025 at 3:45 PM Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 14 Feb 2025, at 18:59, Melanie Plageman <melanieplageman@gmail.com> wrote: > > > > Convert heap_vac_scan_next_block() boolean parameters to flags > > This seems to have made skink upset with a Valgrind error: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-02-14%2020%3A30%3A29 Yep. Thanks. I replied to one of the other commits -- valgrind is mad at two of them. Thomas figured it out and should be committing a fix soon. - Melanie
Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
From
Daniel Gustafsson
Date:
> On 14 Feb 2025, at 22:41, Melanie Plageman <melanieplageman@gmail.com> wrote: > > On Fri, Feb 14, 2025 at 3:45 PM Daniel Gustafsson <daniel@yesql.se> wrote: >> >>> On 14 Feb 2025, at 18:59, Melanie Plageman <melanieplageman@gmail.com> wrote: >>> >>> Convert heap_vac_scan_next_block() boolean parameters to flags >> >> This seems to have made skink upset with a Valgrind error: >> >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-02-14%2020%3A30%3A29 > > Yep. Thanks. I replied to one of the other commits -- valgrind is mad > at two of them. Yeah, I noticed that after I had replied since I first went looking at the wrong threads, sorry for the noise. -- Daniel Gustafsson