Thread: Re: Small memory fixes for pg_createsubcriber
Ranier Vilela <ranier.vf@gmail.com> writes:
> Coverity has some reports about pg_createsubcriber.
> CID 1591322: (#1 of 1): Resource leak (RESOURCE_LEAK)
> 10. leaked_storage: Variable dbname going out of scope leaks the storage it
> points to.
FTR, the security team's Coverity instance also complained about that.
I was planning to fix it after the release freeze lifted, but you
beat me to it, which is fine. Our report turned up a couple other
things that I just pushed fixes for.
(It seems like Coverity must've updated their rules recently,
because we also got a bunch of false-positive reports that were
not there before, mostly in pre-existing code.)
regards, tom lane
Em qua., 12 de fev. de 2025 às 18:17, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Ranier Vilela <ranier.vf@gmail.com> writes:
> Coverity has some reports about pg_createsubcriber.
> CID 1591322: (#1 of 1): Resource leak (RESOURCE_LEAK)
> 10. leaked_storage: Variable dbname going out of scope leaks the storage it
> points to.
FTR, the security team's Coverity instance also complained about that.
I was planning to fix it after the release freeze lifted, but you
beat me to it, which is fine. Our report turned up a couple other
things that I just pushed fixes for.
Yeah, I see the commits, thanks for that.
I still have some reports that I could post that Coverity thinks are bugs.
They are not, but I think it is worth the effort to fix them because the code is confusing.
I think it would improve readability and future maintainability.
(It seems like Coverity must've updated their rules recently,
because we also got a bunch of false-positive reports that were
not there before, mostly in pre-existing code.)
I believe they are trying to innovate at some point.
Many of these false positives come from a risky coding style,
Many of these false positives come from a risky coding style,
I am much more cautious in my analyses.
best regards,
Ranier Vilela