Thread: Re: PgBouncer 1.24.0 - New upstream version

Re: Bradford Boyle
> Hi Christoph,
> 
> I've updated the package for pgbouncer to include a patch based on [0]
> to get the main test suite passing on salsa.debian.org. With this, the
> package should be ready for review and upload.

Hi Bradford,

thanks!

> I've also attached an initial patch to generate-pgdg-source that should
> add the required dependency on python3-contextlib2 and remove the
> dependency on tzdata-legacy to get the pacakge building on older
> distributions.

Unfortunately that needs more work as it looks like:

bookworm and others:

14:54:22 E   AttributeError: 'PGconn' object has no attribute 'close_prepared'

https://jengus.postgresql.org/job/pgbouncer-binaries/106/architecture=amd64,distribution=bookworm/console

bullseye doesn't have python3-psycopg (and building that doesn't look
trivial). Do we think we could go without or with less tests there?

Christoph

On Tue, Feb 4, 2025 at 7:06 AM Christoph Berg <cb@df7cb.de> wrote:
>
> Unfortunately that needs more work as it looks like:
>
> bookworm and others:
>
> 14:54:22 E   AttributeError: 'PGconn' object has no attribute 'close_prepared'
>
> https://jengus.postgresql.org/job/pgbouncer-binaries/106/architecture=amd64,distribution=bookworm/console

Yeah -- it looks like close_prepared was added in psycopg 3.2.0 and
bookworm has 3.1.7. I could patch the tests to include a skipif based on
the version of psycopg.

> bullseye doesn't have python3-psycopg (and building that doesn't look
> trivial). Do we think we could go without or with less tests there?

I think we could go without tests on bullseye since it seems like we are
nearing the trixie release and bullseye will become old old stable.
(Correct me if I am wrong on this point, I'm making this assumption
based on the trixie freeze dates). There's probably little value in
creating extra work here.

It looks like d/rules for pgbouncer will skip the tests if nocheck is in
DEB_BUILD_OPTIONS -- is this something that can be configured via the Jenkins
YAML? I am not very familiar with the Jenkins job builder YAML and I didn't see
any usages of that in the current set of jobs. Or would I need to update
generate-pgdg-source to include an additional tweak to disable the tests on
older platforms?

Thanks,
-- Bradford

Re: Bradford Boyle
> I think we could go without tests on bullseye since it seems like we are
> nearing the trixie release and bullseye will become old old stable.
> (Correct me if I am wrong on this point, I'm making this assumption
> based on the trixie freeze dates). There's probably little value in
> creating extra work here.

Or we just don't update the package on bullseye, leaving it at 1.23.1.
But there is still the autopkgtest, so we still have test coverage
there.

> It looks like d/rules for pgbouncer will skip the tests if nocheck is in
> DEB_BUILD_OPTIONS -- is this something that can be configured via the Jenkins
> YAML? I am not very familiar with the Jenkins job builder YAML and I didn't see
> any usages of that in the current set of jobs. Or would I need to update
> generate-pgdg-source to include an additional tweak to disable the tests on
> older platforms?

Any of these would work.

DEB_BUILD_OPTIONS=nocheck would have to be set in the sbuild-package
script. That's probably the easiest way forward.

The extra test dependencies need annotating with <!nocheck> so the
build doesn't try to install them.

Christoph