Thread: pgsql: Integrate GistTranslateCompareType() into IndexAmTranslateCompar

pgsql: Integrate GistTranslateCompareType() into IndexAmTranslateCompar

From
Peter Eisentraut
Date:
Integrate GistTranslateCompareType() into IndexAmTranslateCompareType()

This turns GistTranslateCompareType() into a callback function of the
gist index AM instead of a standalone function.  The existing callers
are changed to use IndexAmTranslateCompareType().  This then makes
that code not hardcoded toward gist.

This means in particular that the temporal keys code is now
independent of gist.  Also, this generalizes commit 74edabce7a3, so
other index access methods other than the previously hardcoded ones
could now work as REPLICA IDENTITY in a logical replication
subscriber.

Author: Mark Dilger <mark.dilger@enterprisedb.com>
Co-authored-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/622f678c10202c8a0b350794d504eeef7b773e90

Modified Files
--------------
src/backend/access/gist/gist.c             |  2 +-
src/backend/access/gist/gistutil.c         |  8 +------
src/backend/commands/indexcmds.c           | 24 +++++++--------------
src/backend/commands/tablecmds.c           | 28 ++++++------------------
src/backend/executor/execReplication.c     | 34 +-----------------------------
src/backend/replication/logical/relation.c |  8 ++++++-
src/include/access/gist.h                  |  2 +-
src/include/executor/executor.h            |  1 -
8 files changed, 25 insertions(+), 82 deletions(-)