Thread: Re: [PATCH] Fix incorrect range in pg_regress comment

Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> On Sun, 2 Feb 2025 at 22:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, our convention is definitely that the numbers start with 1,
>> so I do not want to make this change.  Maybe we should change
>> the code instead.

> That would require any extensions that use the _0.out suffix to update
> all those files to use _1.out as the suffix. One such extension is
> Citus[1].

Oh.  I see we did document it as 0-9 in [1], so I guess we're
stuck with that now.  Objection withdrawn.

            regards, tom lane

[1] https://www.postgresql.org/docs/devel/regress-variant.html

Michael Paquier <michael@paquier.xyz> writes:
> Right, let's adjust the comment to reflect what the docs say, as your
> patch does.  I presume that Tom will do that..

If I complain about it I gotta fix it, huh?  Okay, done.

            regards, tom lane