Thread: pgsql: Tighten pg_restore's recognition of its -F (format) option value

pgsql: Tighten pg_restore's recognition of its -F (format) option value

From

Tom Lane

Date:

25 January, 22:24:20

Tighten pg_restore's recognition of its -F (format) option values.

Instead of checking just the first letter, match the whole string
using pg_strcasecmp.  Per the documentation, we allow either just
the first letter (e.g. "c") or the whole name ("custom"); but we
will no longer accept random variations such as "chump".  This
matches pg_dump's longstanding parsing code for the same option.

Also for consistency with pg_dump, recognize "p"/"plain".  We don't
support it, but we can give a more helpful error message than
"unrecognized archive format".

Author: Srinath Reddy <srinath2133@gmail.com>
Discussion: https://postgr.es/m/CAFC+b6pfK-BGcWW1kQmtxVrCh-JGjB2X02rLPQs_ZFaDGjZDsQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/04ace176e08f2c694bb66b5b91cbd9d4d0bd77ea

Modified Files
--------------
src/bin/pg_dump/pg_restore.c | 36 +++++++++++++++++-------------------
1 file changed, 17 insertions(+), 19 deletions(-)