Thread: pgsql: Use the correct sizeof() in BufFileLoadBuffer

pgsql: Use the correct sizeof() in BufFileLoadBuffer

From
Tomas Vondra
Date:
Use the correct sizeof() in BufFileLoadBuffer

The sizeof() call should reference buffer.data, because that's the
buffer we're reading data into, not the whole PGAlignedBuffer union.
This was introduced by 44cac93464, which replaced the simple buffer
with a PGAlignedBuffer field.

It's benign, because the buffer is the largest field of the union, so
the sizes are the same. But it's easy to trip over this in a patch, so
fix and backpatch. Commit 44cac93464 went into 12, but that's EOL.

Backpatch-through: 13
Discussion: https://postgr.es/m/928bdab1-6567-449f-98c4-339cd2203b87@vondra.me

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/92598f4fa58da45226b3414d6d880cf4622481a7

Modified Files
--------------
src/backend/storage/file/buffile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)