Thread: Re: Small patch to use pqMsg_Query instead of `Q`

Re: Small patch to use pqMsg_Query instead of `Q`

From
Fabrízio de Royes Mello
Date:

On Tue, Jan 7, 2025 at 12:42 PM Dave Cramer <davecramer@gmail.com> wrote:
Greetings,

Previously we have replaced the use of literal characters with pqMsg*. Not sure how this one escaped detection.

Patch attached.


LGTM... looks like a leftover from f4b54e1e.

Regards,

--
Fabrízio de Royes Mello

Re: Small patch to use pqMsg_Query instead of `Q`

From
Nathan Bossart
Date:
On Tue, Jan 07, 2025 at 01:25:31PM -0300, Fabrízio de Royes Mello wrote:
> On Tue, Jan 7, 2025 at 12:42 PM Dave Cramer <davecramer@gmail.com> wrote:
>> Previously we have replaced the use of literal characters with pqMsg*. Not
>> sure how this one escaped detection.

It's not the first to escape detection, and it probably won't be the
last...

> LGTM... looks like a leftover from f4b54e1e.

I'll commit this shortly.  I'd argue this falls into the category of
"low-risk fixes," so I'll also plan on back-patching it to v17 (where
protocol.h was first added).

-- 
nathan



Re: Small patch to use pqMsg_Query instead of `Q`

From
Nathan Bossart
Date:
Committed.

-- 
nathan